kUTType was deprecated in iOS15, use UTType instead #8093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamgabrielma
added
the
status: draft
iamgabrielma
added
type: enhancement
Collaborator
You can test the changes from this Pull Request by:
|
iamgabrielma
removed
the
status: draft
jaclync
approved these changes
Nov 14, 2022
Contributor
jaclync
left a comment
jaclync
left a comment
There was a problem hiding this comment.
Thanks for fixing the warnings in Yosemite tests! I think we can directly compare and use the identifier of any UTType as a string, left some non-blocking suggestions
Comment on lines
53
to
54
| let gifTypeIdentifier = UTType.gif.identifier as CFString | ||
| if UTTypeEqual(resource.uniformTypeIdentifier as CFString, gifTypeIdentifier) { |
Contributor
There was a problem hiding this comment.
nit: I think comparing the identifier strings directly should be fine?
Suggested change
| let gifTypeIdentifier = UTType.gif.identifier as CFString | |
| if UTTypeEqual(resource.uniformTypeIdentifier as CFString, gifTypeIdentifier) { | |
| if resource.uniformTypeIdentifier == UTType.gif.identifier { |
Comment on lines
127
to
128
| let gifTypeIdentifier = UTType.gif.identifier as CFString | ||
| guard UTTypeEqual(resource.uniformTypeIdentifier as CFString, gifTypeIdentifier) else { |
Contributor
There was a problem hiding this comment.
nit: similar to above, I think direct string comparison is fine?
Suggested change
| let gifTypeIdentifier = UTType.gif.identifier as CFString | |
| guard UTTypeEqual(resource.uniformTypeIdentifier as CFString, gifTypeIdentifier) else { | |
| guard resource.uniformTypeIdentifier == UTType.gif.identifier else { |
Yosemite/YosemiteTests/Tools/Media/MediaImageExporterTests.swift
Outdated
Show resolved
Hide resolved
Yosemite/YosemiteTests/Tools/Media/MediaImageExporterTests.swift
Outdated
Show resolved
Hide resolved
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
From #1767 :
Description
By updating the minimum release version to iOS 15 recently, we've seen some deprecation warnings. This PR fixes the case for uses of
kUTTypeJPEG,kUTTypePNG, andkUTTypeGIF.This PR does not deal with cases for
UTTypeEqual, as it would seems the deprecation message is meant for Objective-C code?Changes
When returning or comparing different file extensions or file types, we change from using
kUUType*, toUTType.*instead.Testing instructions
I'm not 100% sure if I'm handling all test scenarios here, happy to get further feedback about it, but it should be good with the following: